[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <200611062235.28667.arnd@arndb.de>
Date: Mon, 6 Nov 2006 22:35:28 +0100
From: Arnd Bergmann <arnd@...db.de>
To: Hoang-Nam Ngyuen <hnguyen@...ux.vnet.ibm.com>
Cc: rolandd@...co.com, linux-kernel@...r.kernel.org,
linuxppc-dev@...abs.org, openib-general@...nib.org,
hnguyen@...ibm.com, raisch@...ibm.com
Subject: Re: [PATCH 2.6.19 1/4] ehca: assure 4k alignment for firmware control block in 64k page mode
On Monday 06 November 2006 22:26, Hoang-Nam Ngyuen wrote:
> - rblock = kzalloc(H_CB_ALIGNMENT, GFP_KERNEL);
> + rblock = (struct hipz_query_hca*)ehca_alloc_fw_ctrlblock();
>
> - rblock = kzalloc(H_CB_ALIGNMENT, GFP_KERNEL);
> + rblock = (struct hipz_query_port*)ehca_alloc_fw_ctrlblock();
The point Heiko made in his comment is that with ehca_alloc_fw_ctrlblock
returning a void*, you can (and _should_) remove the casts to other
pointer types.
Arnd <><
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists