linux-kernel - Re: [PATCH 2.6.19-rc4] usb auerswald possible memleak fix

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20061107115311.GA18587@suse.de>
Date:	Tue, 7 Nov 2006 20:53:11 +0900
From:	Greg KH <gregkh@...e.de>
To:	Mariusz Kozlowski <m.kozlowski@...land.pl>
Cc:	Wolfgang M?es <wolfgang@...w-muees.de>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2.6.19-rc4] usb auerswald possible memleak fix

On Tue, Nov 07, 2006 at 10:25:14AM +0100, Mariusz Kozlowski wrote:
> Witam, 
> 
> > On Tue, Nov 07, 2006 at 12:31:51AM +0100, Mariusz Kozlowski wrote:
> > > Witam, 
> > > 
> > > > Hello,
> > > > 
> > > > 	There is possible memleak in auerbuf_setup(). Fix is to replace kfree() with auerbuf_free().
> > > > An argument to usb_free_urb() does not need a check as usb_free_urb() already does that. Not sure if I should
> > > > send this in two separate patches. The patch is against 2.6.19-rc4 (not -mm).
> > > 
> > > As I posted the bigger usb_free_urb() patch in another mail this one
> > > should do only one thing which is to fix possible memory leak in
> > > auerbuf_setup().
> > 
> > That is a big patch, care to split it up into smaller pieces like this
> > one so that it is easier to review and apply?
> 
> Sure I can but Andrew already included it in -mm as-is. Do I have to
> prepare another set of patches and send them to you (which is no
> problem to me - just not sure how it works)?

Please just send a new series of patches to me, and then when they show
up in my tree, Andrew will drop his patch.

This will also get you to fix your email client so that you can continue
to send more patches in the future :)

And please CC: usb patches to the linux-usb-devel mailing list, so the
developers there can comment on them if needed.

thanks,

greg k-h
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/