linux-kernel - Re: very small code cleanup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.64.0611071505040.6764@blonde.wat.veritas.com>
Date:	Tue, 7 Nov 2006 15:11:29 +0000 (GMT)
From:	Hugh Dickins <hugh@...itas.com>
To:	Paulo Marques <pmarques@...popie.com>
cc:	Rik Bobbaers <Rik.Bobbaers@...kuleuven.be>,
	linux-kernel@...r.kernel.org, linux-mm@...r.kernel.org
Subject: Re: very small code cleanup

On Tue, 7 Nov 2006, Paulo Marques wrote:
> Rik Bobbaers wrote:
> > 
> > in mm/mlock.c , mm is defined as vma->vm_mm, why not use that one for the
> > decrement of pages?
> 
> Because vma can change here:
> 
> 	if (*prev) {
> 		vma = *prev;
> 		goto success;
> 	}

That's a good piece of cautious observation ...

> 
> and then mm won't be the same as vma->vm_mm..

... but it would be a bug if *prev's vm_mm were different from mm
and from the original vma->vm_mm: Rik's patch looks sensible to me.

Hugh
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/