linux-kernel - Re: [RFC/PATCH] - revert generic_fillattr stat->blksize to PAGE_CACHE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4550AB43.10704@us.ibm.com>
Date:	Tue, 07 Nov 2006 09:50:27 -0600
From:	Steve French <smfltc@...ibm.com>
To:	Dave Kleikamp <shaggy@...ux.vnet.ibm.com>
CC:	Eric Sandeen <sandeen@...hat.com>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	linux-fsdevel <linux-fsdevel@...r.kernel.org>,
	Theodore Tso <tytso@....edu>
Subject: Re: [RFC/PATCH] - revert generic_fillattr stat->blksize to	 	PAGE_CACHE_SIZE

Dave Kleikamp wrote:
> On Tue, 2006-11-07 at 07:40 -0600, Dave Kleikamp wrote:
>   
>> It would probably be best to just set stat->blksize to the negotiated
>> buffer size.
>>     
>
> But be careful here.  I don't know how applications/glibc may behave if
> stat->blksize is not a power of 2.
>   
The man page is not particularly helpful either as it simply indicates:
    "The st_blksize field gives the preferred blocksize for efficient 
file system  I/O. "
but it appears that blksize would affects readdir performance more than 
read/write
(since read/write go through the pagecache and thus readpages/writepages
will request readahead/writebehind for many pages at a time) unless the 
application
opens the file direct i/o.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/