linux-kernel - Re: 2.6.19-rc4: known unfixed regressions (v3)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <m18xinb1qn.fsf@ebiederm.dsl.xmission.com>
Date:	Tue, 07 Nov 2006 10:33:36 -0700
From:	ebiederm@...ssion.com (Eric W. Biederman)
To:	"Bryan O'Sullivan" <bos@...pentine.com>
Cc:	Adrian Bunk <bunk@...sta.de>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	olson@...hscale.com
Subject: Re: 2.6.19-rc4: known unfixed regressions (v3)

"Bryan O'Sullivan" <bos@...pentine.com> writes:

> Eric W. Biederman wrote:
>
>> How comes the driver fixes in the context of my patches?
>
> The fix is simple enough, it's just not as clean as I'd like.  I have to pull
> apart the contents of the ht_irq_msg that the new update hook is getting passed,
> in order to get the vector out, so that I can reprogram the offending chip
> register after I've done the config space writes. It's a pretty roundabout way
> to do the job.

Huh?  As I read the ipath code I am passing you the value that needs to go
into ipath->int_config and thus into dd->ipath_kregs->kr_interrupt_config.

Sure it is coming as 2 32bit words instead of a one big 64 bit one, but
that is simple to fix.

If your card doesn't pay attention to configuration space access cycles then
there should be no reason to write the value there.   If your card does pay
attention to the configuration space access cycles it should be trivial to
make this work.

Please stop getting stuck on your existing hack that only put in the vector
number and didn't put in any of the other interrupt routing information.

If you really need to write to both the config space registers and your
magic shadow copy of the register I can certainly do the config space
writes for you.  I just figured it would be more efficient not to.

Eric
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/