linux-kernel - [PATCH 2.6.19 3/5] dm: multipath: fix rr_add

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20061107183136.GE6993@agk.surrey.redhat.com>
Date:	Tue, 7 Nov 2006 18:31:36 +0000
From:	Alasdair G Kergon <agk@...hat.com>
To:	Andrew Morton <akpm@...l.org>
Cc:	linux-kernel@...r.kernel.org, dm-devel@...hat.com,
	Jonathan E Brassow <jbrassow@...hat.com>
Subject: [PATCH 2.6.19 3/5] dm: multipath: fix rr_add_path order

From: Jonathan E Brassow <jbrassow@...hat.com>

When adding paths to the round-robin path selector, their order gets
inverted, which is not desirable.

Fix by replacing list_add() with list_add_tail().

Signed-off-by: Jonathan E Brassow <jbrassow@...hat.com>
Signed-off-by: Alasdair G Kergon <agk@...hat.com>
Cc: dm-devel@...hat.com

Index: linux-2.6.19-rc4/drivers/md/dm-round-robin.c
===================================================================
--- linux-2.6.19-rc4.orig/drivers/md/dm-round-robin.c	2006-11-07 17:06:19.000000000 +0000
+++ linux-2.6.19-rc4/drivers/md/dm-round-robin.c	2006-11-07 17:07:59.000000000 +0000
@@ -136,7 +136,7 @@ static int rr_add_path(struct path_selec
 
 	path->pscontext = pi;
 
-	list_add(&pi->list, &s->valid_paths);
+	list_add_tail(&pi->list, &s->valid_paths);
 
 	return 0;
 }
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/