lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20061107040744.GA23641@kroah.com>
Date:	Tue, 7 Nov 2006 13:07:44 +0900
From:	Greg KH <greg@...ah.com>
To:	Dave Jones <davej@...hat.com>, Alan Cox <alan@...rguk.ukuu.org.uk>,
	Sergio Monteiro Basto <sergio@...giomb.no-ip.org>,
	akpm@...l.org, Wilco Beekhuizen <wilcobeekhuizen@...il.com>,
	linux-kernel@...r.kernel.org
Subject: Re: VIA IRQ quirk missing PCI ids since 2.6.16.17

On Mon, Nov 06, 2006 at 08:25:19PM -0500, Dave Jones wrote:
> On Mon, Nov 06, 2006 at 09:13:45PM +0000, Alan Cox wrote:
> 
>  > +static const struct pci_device_id via_vlink_fixup_tbl[] = {
>  > +	{ PCI_VDEVICE(VIA, PCI_DEVICE_ID_VIA_8233_0), 17},
>  > +	{ PCI_VDEVICE(VIA, PCI_DEVICE_ID_VIA_8233A), 17 },
>  > +	{ PCI_VDEVICE(VIA, PCI_DEVICE_ID_VIA_8233C_0), 17 },
>  > +	{ PCI_VDEVICE(VIA, PCI_DEVICE_ID_VIA_8235), 16 },
>  > +	/* May not be needed for the 8237 */
>  > +	{ PCI_VDEVICE(VIA, PCI_DEVICE_ID_VIA_8237), 15 },
>  > +	{ PCI_VDEVICE(VIA, PCI_DEVICE_ID_VIA_8237A), 15 },
>  >  	{ 0, },
> 
> This got me wondering what PCI_VDEVICE was, so I went looking.
> It's a libata'ism it seems with the comment..
> 
> /* move to PCI layer? */

I have no objection to moving this to pci.h.  Feel free to send me a
patch.

thanks,

greg k-h
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ