linux-kernel - Re: [PATCH 2.6.19-rc4] usb urb unlink/free clenup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200611071030.57152.m.kozlowski@tuxland.pl>
Date:	Tue, 7 Nov 2006 10:30:56 +0100
From:	Mariusz Kozlowski <m.kozlowski@...land.pl>
To:	Andrew Morton <akpm@...l.org>
Cc:	Greg KH <greg@...ah.com>, linux-kernel@...r.kernel.org,
	linux-usb-devel@...ts.sourceforge.net
Subject: Re: [PATCH 2.6.19-rc4] usb urb unlink/free clenup

Hello, 

> > We do not need to check for urb != NULL before we call them.
> 
> Seems reasonable.
> 
> Your patch had all its tabs replaced with spaces by your email client.  I
> fixed that all up, but it was rather dull work and I'd prefer not to have
> to do it again.

Will investigate - hopefully won't happen again. Sorry.

> > Or maybe there is no need for this?
> > 
> 
> I think it's OK as-is.  Presumably it's rare for a caller to pass in a NULL
> urb.
> 
> It's possible that your proposed change will cause new (and incorrect)
> warnings to be emitted, but we can handle those if/when they come out.

Ok here is the dumb part. Do I send the next diff against the work I already did?

Regards,

	Mariusz Kozlowski
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/