linux-kernel - Re: [PATCH] NFS4 fix for recursive locking problem.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20061107002657.GN12372@fieldses.org>
Date:	Mon, 6 Nov 2006 19:26:57 -0500
From:	"J. Bruce Fields" <bfields@...ldses.org>
To:	Srinivasa Ds <srinivasa@...ibm.com>
Cc:	linux-kernel@...r.kernel.org, akpm@...l.org, neilb@...e.de,
	nfs@...ts.sourceforge.net, andros@...i.umich.edu
Subject: Re: [PATCH] NFS4  fix for recursive locking problem.

On Tue, Oct 31, 2006 at 07:24:56PM +0530, Srinivasa Ds wrote:
> When I was performing some operations on NFS, I got below error on server 
> side.
> 
> ===========================================================
> 
> =============================================
> [ INFO: possible recursive locking detected ]
> 2.6.19-prep #1
...
> So I have developed the patch to overcome this problem. Please let me know 
> your comments on this.

Looks right, thanks!

--b.

> Signed-off-by: Srinivasa DS <srinivasa@...ibm.com>
> 
> 
> 

>  nfs4recover.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> Index: linux-2.6.19-rc3/fs/nfsd/nfs4recover.c
> ===================================================================
> --- linux-2.6.19-rc3.orig/fs/nfsd/nfs4recover.c	2006-10-24 04:32:02.000000000 +0530
> +++ linux-2.6.19-rc3/fs/nfsd/nfs4recover.c	2006-10-31 18:27:30.000000000 +0530
> @@ -274,7 +274,7 @@
>  	 * any regular files anyway, just in case the directory was created by
>  	 * a kernel from the future.... */
>  	nfsd4_list_rec_dir(dentry, nfsd4_remove_clid_file);
> -	mutex_lock(&dir->d_inode->i_mutex);
> +	mutex_lock_nested(&dir->d_inode->i_mutex, I_MUTEX_PARENT);
>  	status = vfs_rmdir(dir->d_inode, dentry);
>  	mutex_unlock(&dir->d_inode->i_mutex);
>  	return status;

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/