linux-kernel - Re: [PATCH 0/14] KVM: Kernel-based Virtual Machine (v4)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4551AD0A.4080309@qumranet.com>
Date:	Wed, 08 Nov 2006 12:10:18 +0200
From:	Avi Kivity <avi@...ranet.com>
To:	Arjan van de Ven <arjan@...radead.org>
CC:	Andrew Morton <akpm@...l.org>, Roland Dreier <rdreier@...co.com>,
	kvm-devel@...ts.sourceforge.net, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 0/14] KVM: Kernel-based Virtual Machine (v4)

Arjan van de Ven wrote:
>> The problem with that is that the test comes too late: after we've 
>> configured.  Andrew wants to keep allmodconfig working, and for that we 
>> need to deselect CONFIG_KVM before compilation starts.
>>     
>
> not really. You can also select to just not compile kvm at all *from the
> Makefile*
>   

Yes.  And then a real user (not an allmodconfig user) selects CONFIG_KVM 
and wonders where it went.

For users, we want it to fail fatally.  For allmodconfig, we want it to 
succeed but don't care about the output.


>> gcc.*protector.sh only affects the Makefile, not the configuration, AFAICT.
>>     
>
> but it is the Makefile that goes into the kvm directory and compiles
> stuff!
>
> yes it's ugly and not so elegant, but it's effective and you can warn
> bigtime via nasty messages if you want ;)
>   

We already have an ugly solution:

    #define VMLAUNCH ".byte 0x0f, foo, bar"

etc.  We were looking for an elegant one.

-- 
error compiling committee.c: too many arguments to function

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/