linux-kernel - Re: + i386-lapic-timer-calibration.patch added to -mm tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1162988830.8335.33.camel@localhost.localdomain>
Date:	Wed, 08 Nov 2006 13:27:10 +0100
From:	Thomas Gleixner <tglx@...utronix.de>
To:	Ingo Molnar <mingo@...e.hu>
Cc:	linux-kernel@...r.kernel.org, mm-commits@...r.kernel.org,
	Andrew Morton <akpm@...l.org>
Subject: Re: + i386-lapic-timer-calibration.patch added to -mm tree

On Wed, 2006-11-08 at 13:09 +0100, Ingo Molnar wrote:
> one question:
> 
> > +	long tapic = apic_read(APIC_TMCCT);
> > +	unsigned long pm = acpi_pm_read_early();
> 
> is this function call safe if the box has no pm-timer?

That's in the pm-timer-allow-early-access.patch:

Subject: pmtimer: Allow early access to pm timer

+static inline u32 acpi_pm_read_early(void)
+{
+       if (!pmtmr_ioport)
+               return 0;
+       /* mask the output to 24 bits */
+       return acpi_pm_read_verified();
+}

If pmtmr is not available, the function returns 0, so the resulting
delta is 0 and therefor ignored. Same applies, when PMTIMER is disabled
in the config.

	tglx


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/