linux-kernel - Re: S2RAM and PCI quirks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1163000924.3138.342.camel@laptopd505.fenrus.org>
Date:	Wed, 08 Nov 2006 16:48:44 +0100
From:	Arjan van de Ven <arjan@...radead.org>
To:	Alan Cox <alan@...rguk.ukuu.org.uk>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: S2RAM and PCI quirks

On Wed, 2006-11-08 at 15:45 +0000, Alan Cox wrote:
> I'm tracing down a case where suspend to ram/resume from RAM causes
> horrible corruption but not immediately. From a PCI dump it appears that
> we are not running the PCI quirks again on the S2RAM resume. Is this
> actually the case or am I missing something scanning through the code.
> If it is the case then we have multiple corruptors lurking because the
> PCI config restore doesn't cover the special registers that need poking
> in some cases.

at the same time I'm not 100% convinced it's ok to always run all quirks
at resume, for one the difference is that there now is a driver active
owning the device... Almost sounds like having a per quirk flag stating
"run at resume" is needed ;-(

(also I think the quirks are currently __init but that's relatively easy
to fix)

-- 
if you want to mail me at work (you don't), use arjan (at) linux.intel.com
Test the interaction between Linux and your BIOS via http://www.linuxfirmwarekit.org

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/