linux-kernel - Re: [PATCH] Fix sys_move_pages when a NULL node list is passed.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20061108115732.fcd17f67.kamezawa.hiroyu@jp.fujitsu.com>
Date:	Wed, 8 Nov 2006 11:57:32 +0900
From:	KAMEZAWA Hiroyuki <kamezawa.hiroyu@...fujitsu.com>
To:	Stephen Rothwell <sfr@...b.auug.org.au>
Cc:	clameter@....com, linux-kernel@...r.kernel.org, linux-mm@...ck.org,
	stable@...nel.org, akpm@...l.org
Subject: Re: [PATCH] Fix sys_move_pages when a NULL node list is passed.

On Wed, 8 Nov 2006 13:47:44 +1100
Stephen Rothwell <sfr@...b.auug.org.au> wrote:

> On Wed, 8 Nov 2006 11:13:41 +0900 KAMEZAWA Hiroyuki <kamezawa.hiroyu@...fujitsu.com> wrote:
> >
> > Ah.. I'm mentioning to this.
> > ==
> > +			pm[i].node = 0;	/* anything to not match MAX_NUMNODES */
> > ==
> > Sorry for my bad cut & paste.
> >
> > It seems that this 0 will be passed to alloc_pages_node().
> > alloc_pages_node() doesn't check whether a node is online or not before using
> > NODE_DATA().
> 
> Actually, it won't.  If you do that assignment, then the nodes parameter
> was NULL and you will only call do_pages_stat() and so never call
> alloc_pages_node().
> 
Ah..Okay, I'm sorry for noise.

-Kame

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/