linux-kernel - Re: [PATCH] ipmi_si_intf.c: fix "&& 0xff" typos

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 09 Nov 2006 08:45:28 -0600
From:	Corey Minyard <minyard@....org>
To:	Valdis.Kletnieks@...edu
CC:	Alexey Dobriyan <adobriyan@...il.com>,
	Andrew Morton <akpm@...l.org>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ipmi_si_intf.c: fix "&& 0xff" typos

Valdis.Kletnieks@...edu wrote:
> On Wed, 08 Nov 2006 16:15:46 CST, Corey Minyard said:
>   
>> Ouch, I guess we've never had a system with these address types.  Thanks.
>>     
>
> If we never had a system with these address types..
>
>   
>>>  static unsigned char intf_mem_inw(struct si_sm_io *io, unsigned int offset)
>>>  {
>>>  	return (readw((io->addr)+(offset * io->regspacing)) >> io->regshift)
>>> -		&& 0xff;
>>> +		& 0xff;
>>>  }
>>>       
>
> Is this dead code that isn't called by anybody?
>   
Well, not exactly.  The SMBIOS or ACPI tables that report these interfaces
have various options for the size of the device registers.  The driver
implements all the options, but there may or may not be systems with
every option available.  But I can't exactly guess what is available in the
field.

-Corey

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/