| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Thu, 09 Nov 2006 11:40:54 -0500
From: Michael Krufky <mkrufky@...uxtv.org>
To: Alexey Dobriyan <adobriyan@...il.com>
CC: Andrew Morton <akpm@...l.org>, v4l-dvb-maintainer@...uxtv.org,
linux-kernel@...r.kernel.org, Patrick Boettcher <pb@...uxtv.org>
Subject: Re: [v4l-dvb-maintainer] [PATCH] flexcop-usb.c: fix "&& 0xff" typos
and ...
Alexey Dobriyan wrote:
> .. fix debug printk. Why, oh why, one would want to do
>
> (u16 & 0xff) << 8
>
> and print it with %02x format?
>
> Signed-off-by: Alexey Dobriyan <adobriyan@...il.com>
I spoke to Patrick in irc and confirmed the fix...
Acked-by: Patrick Boettcher <pb@...uxtv.org>
Signed-off-by: Michael Krufky <mkrufky@...uxtv.org>
> ---
>
> drivers/media/dvb/b2c2/flexcop-usb.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- a/drivers/media/dvb/b2c2/flexcop-usb.c
> +++ b/drivers/media/dvb/b2c2/flexcop-usb.c
> @@ -246,7 +246,7 @@ static int flexcop_usb_i2c_req(struct fl
> wIndex = (chipaddr << 8 ) | addr;
>
> deb_i2c("i2c %2d: %02x %02x %02x %02x %02x %02x\n",func,request_type,req,
> - ((wValue && 0xff) << 8),wValue >> 8,((wIndex && 0xff) << 8),wIndex >> 8);
> + wValue & 0xff, wValue >> 8, wIndex & 0xff, wIndex >> 8);
>
> len = usb_control_msg(fc_usb->udev,pipe,
> req,
>
>
> _______________________________________________
> v4l-dvb-maintainer mailing list
> v4l-dvb-maintainer@...uxtv.org
> http://www.linuxtv.org/cgi-bin/mailman/listinfo/v4l-dvb-maintainer
--
Michael Krufky
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists