linux-kernel - Re: [PATCH 2/3] new_inode_autonum: convert filesystems to use new function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <45536270.2040505@sandeen.net>
Date:	Thu, 09 Nov 2006 11:16:32 -0600
From:	Eric Sandeen <sandeen@...deen.net>
To:	Jeff Layton <jlayton@...hat.com>
CC:	linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org,
	akpm@...l.org
Subject: Re: [PATCH 2/3] new_inode_autonum: convert filesystems to use new
 function

Jeff Layton wrote:
> This patch converts all in-tree filesystems that blindly use the i_ino 
> value given by new_inode to use new_inode_autonum. Also fix up a few
> other cases where i_ino might not end up being unique.

After looking at this, since you have to change all of these filesystems
anyway, I'm not sure there's a lot of value in having
new_inode_autonum(); they all previously called new_inode() and then
filled in a few fields of the new inode.  Why not just call new_inode(),
and add a call to inode->i_inum = iunique(sb, 0)?  We don't have
new_inode_autouid() or new_inode_autoatime(), why is i_ino special in
this regard?

-Eric
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/