linux-kernel - [patch] fix up generic csum_ipv6

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <000301c703a3$0eedb340$ff0da8c0@amr.corp.intel.com>
Date:	Wed, 8 Nov 2006 18:02:06 -0800
From:	"Chen, Kenneth W" <kenneth.w.chen@...el.com>
To:	"'Andrew Morton'" <akpm@...l.org>,
	"'Jeff Garzik'" <jgarzik@...ox.com>, <davem@...emloft.net>
Cc:	"'Linux Kernel Mailing List'" <linux-kernel@...r.kernel.org>,
	"'NetDev'" <netdev@...r.kernel.org>
Subject: [patch] fix up generic csum_ipv6_magic function prototype

The generic version of csum_ipv6_magic has the len argument declared as
__u16, while most arch dependent version declare it as __u32.  After
looking at the call site of this function, I come up to a conclusion
that __u32 is a better match with the actual usage.

Hence, patch to change argument type for greater consistency.


Signed-off-by: Ken Chen <kenneth.w.chen@...el.com>


---

asm-m32r and asm-parisc both have it declared as __u16. I think it is a
copy-n-paste error and needs to be fixed by arch maintainer, I hope.



--- ./include/net/ip6_checksum.h.orig	2006-11-08 18:49:50.000000000 -0800
+++ ./include/net/ip6_checksum.h	2006-11-08 18:50:04.000000000 -0800
@@ -36,7 +36,7 @@
 
 static __inline__ unsigned short int csum_ipv6_magic(struct in6_addr *saddr,
 						     struct in6_addr *daddr,
-						     __u16 len,
+						     __u32 len,
 						     unsigned short proto,
 						     unsigned int csum) 
 {

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/