linux-kernel - Re: [PATCH][TRIVIAL] drivers/ide: stray bracket

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sat, 11 Nov 2006 17:21:12 +0100
From:	Nicolas Kaiser <nikai@...ai.net>
To:	Alexey Dobriyan <adobriyan@...il.com>
Cc:	linux-ide@...r.kernel.org, trivial@...nel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH][TRIVIAL] drivers/ide: stray bracket

* Alexey Dobriyan <adobriyan@...il.com>:
> On Sat, Nov 11, 2006 at 01:47:56AM +0100, Nicolas Kaiser wrote:
> > Stray bracket in debug code.

> Just remove whole printk. It was broken for a looong time.

If you prefer it that way, here we go:
Remove debug code that was broken for long time.

Signed-off-by: Nicolas Kaiser <nikai@...ai.net>
---

 drivers/ide/legacy/hd.c |    5 -----
 1 file changed, 5 deletions(-)

diff -uprN a/drivers/ide/legacy/hd.c b/drivers/ide/legacy/hd.c
--- a/drivers/ide/legacy/hd.c	2006-09-20 05:42:06.000000000 +0200
+++ b/drivers/ide/legacy/hd.c	2006-11-11 17:11:28.000000000 +0100
@@ -456,11 +456,6 @@ ok_to_read:
 	req->errors = 0;
 	i = --req->nr_sectors;
 	--req->current_nr_sectors;
-#ifdef DEBUG
-	printk("%s: read: sector %ld, remaining = %ld, buffer=%p\n",
-		req->rq_disk->disk_name, req->sector, req->nr_sectors,
-		req->buffer+512));
-#endif
 	if (req->current_nr_sectors <= 0)
 		end_request(req, 1);
 	if (i > 0) {
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/