linux-kernel - Re: [linux-usb-devel] drivers/usb/gadget/ether.c: NULL dereference

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200611112310.18903.david-b@pacbell.net>
Date:	Sat, 11 Nov 2006 23:10:17 -0800
From:	David Brownell <david-b@...bell.net>
To:	Adrian Bunk <bunk@...sta.de>
Cc:	linux-usb-devel@...ts.sourceforge.net, greg@...ah.com,
	linux-kernel@...r.kernel.org
Subject: Re: [linux-usb-devel] drivers/usb/gadget/ether.c: NULL dereference


> 
> void dev_kfree_skb_any(struct sk_buff *skb)
> {
>         if (in_irq() || irqs_disabled())
>                 dev_kfree_skb_irq(skb);
>         else
>                 dev_kfree_skb(skb);
> }
> 
> 
> And the first thing dev_kfree_skb_irq() does is to dereference skb...

Yet dev_kfree_skb() --> kfree_skb() starts with the standard idiom

	if (unlikely(!skb))
		return

Seems to me that the finger of blame is more appropriately pointed
at either dev_kfree_skb_any() or dev_kfree_skb_irq() ...

- Dave

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/