linux-kernel - Re: [PATCH 2.6.19-rc5-git2] EFI: mapping memory region of runtime services when using memmap kernel parameter

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <p73u013307r.fsf@bingen.suse.de>
Date:	13 Nov 2006 15:11:52 +0100
From:	Andi Kleen <ak@...e.de>
To:	"Myaskouvskey, Artiom" <artiom.myaskouvskey@...el.com>
Cc:	<linux-kernel@...r.kernel.org>, "Satt, Shai" <shai.satt@...el.com>
Subject: Re: [PATCH 2.6.19-rc5-git2]  EFI: mapping memory region of runtime services when using memmap kernel parameter

"Myaskouvskey, Artiom" <artiom.myaskouvskey@...el.com> writes:
>  
> +extern int is_available_memory(efi_memory_desc_t * md);

Never put externs into .c files

The whole approach of including the run time services into
the memory map seems bogus. How about ioremap()ing (or fixmaping) them
on demand instead?

-Andi
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/