linux-kernel - Re: [PATCH] Apple Motion Sensor driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d120d5000611130753p172c2a69n260482052f623a46@mail.gmail.com>
Date:	Mon, 13 Nov 2006 10:53:19 -0500
From:	"Dmitry Torokhov" <dmitry.torokhov@...il.com>
To:	"Stelian Pop" <stelian@...ies.net>
Cc:	"Andrew Morton" <akpm@...l.org>,
	"Michael Hanselmann" <linux-kernel@...smi.ch>,
	"Aristeu S. Rozanski F." <aris@...hedrallabs.org>,
	"Johannes Berg" <johannes@...solutions.net>,
	"Benjamin Herrenschmidt" <benh@...nel.crashing.org>,
	"Paul Mackerras" <paulus@...ba.org>,
	"Robert Love" <rml@...ell.com>,
	"Jean Delvare" <khali@...ux-fr.org>,
	"Rene Nussbaumer" <linux-kernel@...lerfox.forkbomb.ch>,
	"Linux Kernel Mailing List" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] Apple Motion Sensor driver

On 11/13/06, Stelian Pop <stelian@...ies.net> wrote:
> Le lundi 13 novembre 2006 à 10:04 -0500, Dmitry Torokhov a écrit :
> > Hi Stelian,
> >
> > On 11/11/06, Stelian Pop <stelian@...ies.net> wrote:
> >
> >  +
> > > +       if (input_register_device(ams_info.idev)) {
> > > +               input_free_device(ams_info.idev);
> > > +               ams_info.idev = NULL;
> > > +               return;
> > > +       }
> > > +
> > > +       ams_info.kthread = kthread_run(ams_mouse_kthread, NULL, "kams");
> > > +       if (IS_ERR(ams_info.kthread)) {
> > > +               input_unregister_device(ams_info.idev);
> > > +               ams_info.idev = NULL;
> > > +               return;
> > > +       }
> > > +}
> >
> > Please consider implementing ams_mouse_start() and ams_mouse_stop()
> > methods for input_dev and start/stop polling thread there - there is
> > no reason to report input events when noone listens to them.
>
> I suppose you talk about input_dev->open() and close() ?
>

Yep.

> +
> +static int ams_mouse_open(struct input_dev *dev)
> +{
> +       ams_info.kthread = kthread_run(ams_mouse_kthread, NULL, "kams");
> +       return IS_ERR(ams_info.kthread) ? -ENODEV : 0;
> +}
> +

Is there a reason why you reporting -ENODEV instead of real error code
from kthread_run()?

-- 
Dmitry
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/