linux-kernel - Re: [PATCH] Apple Motion Sensor driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20061113191444.1519bdb9.khali@linux-fr.org>
Date:	Mon, 13 Nov 2006 19:14:44 +0100
From:	Jean Delvare <khali@...ux-fr.org>
To:	Johannes Berg <johannes@...solutions.net>
Cc:	Stelian Pop <stelian@...ies.net>,
	Dmitry Torokhov <dmitry.torokhov@...il.com>,
	Andrew Morton <akpm@...l.org>,
	Michael Hanselmann <linux-kernel@...smi.ch>,
	"Aristeu S. Rozanski F." <aris@...hedrallabs.org>,
	Benjamin Herrenschmidt <benh@...nel.crashing.org>,
	Paul Mackerras <paulus@...ba.org>,
	Robert Love <rml@...ell.com>,
	Rene Nussbaumer <linux-kernel@...lerfox.forkbomb.ch>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] Apple Motion Sensor driver

On Mon, 13 Nov 2006 17:20:26 +0100, Johannes Berg wrote:
> On Mon, 2006-11-13 at 17:14 +0100, Stelian Pop wrote:
> > 
> > +               input_report_abs(ams_info.idev, ABS_X, x - ams_info.xcalib);
> > +               input_report_abs(ams_info.idev, ABS_Y, y - ams_info.ycalib);
> > +               input_report_abs(ams_info.idev, ABS_Z, z - ams_info.zcalib); 
> 
> Sorry about chiming in so late. When I tried to use this with neverball,
> ams_info.xcalib - x (and similar for the others) was more useful because
> of the way things are oriented. If I tilt my powerbook to the left then
> with this original code the mouse cursor moves to the right which is
> contrary to what neverball expects.
> 
> Not sure if we want to change this or not, it sort of boils down to a
> userspace issue and we could just patch neverball to have a direction
> inversion :)

For what it's worth, the hdaps driver offers a parameter to invert the
axes at the driver level. It sounds sane to me, as ideally we should be
able to detect it from the hardware, and user-space should not need to
care about hardware specific details.

-- 
Jean Delvare
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/