linux-kernel - Re: [PATCH] Apple Motion Sensor driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d120d5000611131020y69bdada1hfe694583312f9b61@mail.gmail.com>
Date:	Mon, 13 Nov 2006 13:20:37 -0500
From:	"Dmitry Torokhov" <dmitry.torokhov@...il.com>
To:	"Stelian Pop" <stelian@...ies.net>
Cc:	"Andrew Morton" <akpm@...l.org>,
	"Michael Hanselmann" <linux-kernel@...smi.ch>,
	"Aristeu S. Rozanski F." <aris@...hedrallabs.org>,
	"Johannes Berg" <johannes@...solutions.net>,
	"Benjamin Herrenschmidt" <benh@...nel.crashing.org>,
	"Paul Mackerras" <paulus@...ba.org>,
	"Robert Love" <rml@...ell.com>,
	"Jean Delvare" <khali@...ux-fr.org>,
	"Rene Nussbaumer" <linux-kernel@...lerfox.forkbomb.ch>,
	"Linux Kernel Mailing List" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] Apple Motion Sensor driver

On 11/13/06, Stelian Pop <stelian@...ies.net> wrote:
> Le lundi 13 novembre 2006 à 10:53 -0500, Dmitry Torokhov a écrit :
>
> > > +       return IS_ERR(ams_info.kthread) ? -ENODEV : 0;
>
> > Is there a reason why you reporting -ENODEV instead of real error code
> > from kthread_run()?
>
> Euh... :)
>
> Here it comes again:
>

Great :) Now I wonder if I may ask you to change name of the module
option from "mouse" to "joystick" (HP driver uses this name as well)
because its functionality is closer to a joystick than a mouse.

Otherwise you can have my Acked-by for the input part.

-- 
Dmitry
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/