linux-kernel - Re: [PATCH] Apple Motion Sensor driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1163453039.5399.19.camel@johannes.berg>
Date:	Mon, 13 Nov 2006 22:23:59 +0100
From:	Johannes Berg <johannes@...solutions.net>
To:	Stelian Pop <stelian@...ies.net>
Cc:	Dmitry Torokhov <dmitry.torokhov@...il.com>,
	Andrew Morton <akpm@...l.org>,
	Michael Hanselmann <linux-kernel@...smi.ch>,
	"Aristeu S. Rozanski F." <aris@...hedrallabs.org>,
	Benjamin Herrenschmidt <benh@...nel.crashing.org>,
	Paul Mackerras <paulus@...ba.org>,
	Robert Love <rml@...ell.com>,
	Jean Delvare <khali@...ux-fr.org>,
	Rene Nussbaumer <linux-kernel@...lerfox.forkbomb.ch>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] Apple Motion Sensor driver


> The fact that the accelerometer offers a (low res) joystick emulation is
> only a nice hack and I'm not even sure somebody (except Johannes) will
> find an use for it.

Heh. Well I think it's fun once a while :)

On Mon, 2006-11-13 at 21:52 +0100, Stelian Pop wrote:
> 
> +               x -= ams_info.xcalib;
> +               y -= ams_info.ycalib;
> +               z -= ams_info.zcalib;
> +
> +               input_report_abs(ams_info.idev, ABS_X, invert ? -x : x);
> +               input_report_abs(ams_info.idev, ABS_Y, invert ? -y : y);
> +               input_report_abs(ams_info.idev, ABS_Z, z - ams_info.zcalib); 

You're double-calibrating z now, which is surely not what was intended.

johannes

Download attachment "signature.asc" of type "application/pgp-signature" (829 bytes)