linux-kernel - [-mm patch] fix the DLM dependencies.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20061114183324.GL22565@stusta.de>
Date:	Tue, 14 Nov 2006 19:33:24 +0100
From:	Adrian Bunk <bunk@...sta.de>
To:	Andrew Morton <akpm@...l.org>,
	Steven Whitehouse <swhiteho@...hat.com>, pcaulfie@...hat.com,
	teigland@...hat.com
Cc:	linux-kernel@...r.kernel.org, cluster-devel@...hat.com
Subject: [-mm patch] fix the DLM dependencies.

On Tue, Nov 14, 2006 at 01:41:25AM -0800, Andrew Morton wrote:
>...
> - A nasty Kconfig warning comes out during the build.  It's due to
>   git-gfs2-nmw.patch.
>...

So let's fix it.  ;-)

cu
Adrian


<--  snip  -->


Kconfig said:
Warning! Found recursive dependency: INET IPV6 DLM (null) DLM_TCP INET

Due to the "depends on IPV6 || IPV6=n" it's not really a circular 
dependency, but there's another bug that anyway should be fixed:
The "select IP_SCTP" ignored the dependency of IP_SCTP on INET.

Considering that:
- there's no way to use DLM with INET=n and
- INET=n being a mostly pathological case
this patch fixes both this bug and the "recursive dependency" warning by 
letting DLM depend on INET again.

Signed-off-by: Adrian Bunk <bunk@...sta.de>

--- linux-2.6.19-rc5-mm2/fs/dlm/Kconfig.old	2006-11-14 18:41:35.000000000 +0100
+++ linux-2.6.19-rc5-mm2/fs/dlm/Kconfig	2006-11-14 18:44:12.000000000 +0100
@@ -1,5 +1,5 @@
 menu "Distributed Lock Manager"
-	depends on EXPERIMENTAL
+	depends on EXPERIMENTAL && INET
 
 config DLM
 	tristate "Distributed Lock Manager (DLM)"
@@ -20,7 +20,6 @@ choice
 
 config DLM_TCP
 	bool "TCP/IP"
-	select INET
 
 config DLM_SCTP
 	bool "SCTP"

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/