lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 14 Nov 2006 20:04:25 +0100 From: Jens Axboe <jens.axboe@...cle.com> To: Alex Romosan <romosan@...orax.lbl.gov> Cc: linux-kernel@...r.kernel.org Subject: Re: 2.6.19-rc1 (+ide-cd patches) regression: unable to rip cd On Tue, Nov 14 2006, Alex Romosan wrote: > Jens Axboe <jens.axboe@...cle.com> writes: > > > There is a second error handling patch merged with the first patch as > > well, perhaps it'll help you out. Attached here as well. > > > > diff --git a/drivers/ide/ide-cd.c b/drivers/ide/ide-cd.c > > index bddfebd..8821494 100644 > > --- a/drivers/ide/ide-cd.c > > +++ b/drivers/ide/ide-cd.c > > @@ -724,7 +724,7 @@ static int cdrom_decode_status(ide_drive > > * if we have an error, pass back CHECK_CONDITION as the > > * scsi status byte > > */ > > - if (!rq->errors) > > + if (blk_pc_request(rq) && !rq->errors) > > rq->errors = SAM_STAT_CHECK_CONDITION; > > > > /* Check for tray open. */ > > > > tried it again with this patch (on top of all the other patches). > overall things are much better than they've been in a long time > (thanks!), but... when cdparanoia gets stuck, if i abort the process > and restart it the ripping proceeds very slowly (~5x before, ~1.5x > after). if i eject/insert the cd and then restart cdparanoia the speed > is as before (~5x). something doesn't get reset until the cd is > ejected, don't know if it's the kernel's fault though. same thing > happens if i get an error reading a sector but then cdparanoia manages > to recover. from that point on the speed is very slow (again until i > eject/insert the cd; a new instance of cdparanoia is just as slow). When cdparanoia gets stuck, how is it stuck? Can you give me a backtrace of that? If you can abort it, sounds like it isn't stuck in the kernel. -- Jens Axboe - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists