linux-kernel - Re: [PATCH 2.6.19-rc5] hwmon: HP Mobile data protection system 3D driver version 0.5

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <d120d5000611141216o1a38c319kdd1c59694620eb9a@mail.gmail.com>
Date:	Tue, 14 Nov 2006 15:16:58 -0500
From:	"Dmitry Torokhov" <dmitry.torokhov@...il.com>
To:	"Burman Yan" <yan_952@...mail.com>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2.6.19-rc5] hwmon: HP Mobile data protection system 3D driver version 0.5

On 11/14/06, Burman Yan <yan_952@...mail.com> wrote:
> Hi.
>
> I took into account previous remarks, so here is the new version of the
> driver
> for the accelerometer present in HP nc6400 laptops. See documentation in the
> patch
> for complete feature list. At this point I don't think there is anything
> more that can
> be added to this driver and also it works stable for me no matter how I
> tried to abuse it.
>

Hi,

I don't think that you need a spinlock to protect mdps.count. Just
make it atomic_t and use atomic_xchg(&mdps.count, 0) in
mdaps_misc_read to get and reset it.

Also why are you settng EV_KEY bit on the input device? You are not
reporintg any key events...

-- 
Dmitry
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/