linux-kernel - Re: [PATCH] sas_ata: satisfy libata qc function locking requirements

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <455A4C17.5000902@garzik.org>
Date:	Tue, 14 Nov 2006 18:07:03 -0500
From:	Jeff Garzik <jeff@...zik.org>
To:	"Darrick J. Wong" <djwong@...ibm.com>
CC:	linux-scsi <linux-scsi@...r.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Alexis Bruemmer <alexisb@...ibm.com>
Subject: Re: [PATCH] sas_ata: satisfy libata qc function locking requirements

Darrick J. Wong wrote:
> ata_qc_complete and ata_sas_queuecmd require that the port lock be held
> when they are called.  sas_ata doesn't do this, leading to BUG messages
> about qc tags newly allocated qc tags already being in use.  This patch
> fixes the locking, which should clean up the rest of those messages.
> 
> So far I've tested this against an IBM x206m with two SATA disks with no
> BUG messages and no other signs of things going wrong, and the machine
> finally passed the pounder stress test.  The patch is against jejb's
> aic94xx-sas tree.
> 
> --
> 
> Signed-off-by: Darrick J. Wong <djwong@...ibm.com>

heh, yeah, proper locking helps :)

Glad to hear the progress.  Adaptec just sent me a cable that will allow 
me to use my Razor card as a SATA controller, so I can finally start 
testing that.

	Jeff



-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/