lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Mon, 13 Nov 2006 19:41:17 -0700
From: (Eric W. Biederman)
To:	Andi Kleen <>
	linux kernel mailing list <>,
	Reloc Kernel List <>,,,,,
Subject: Re: [RFC] [PATCH 2/16] x86_64: Assembly safe page.h and pgtable.h

Andi Kleen <> writes:

>> I think we need these UL suffixes. Otherwise in some cases overflow
>> can take place and compiler emits warning.
>> For ex. in following definition I got rid of UL.
>> #define PGDIR_SIZE      (1 << PGDIR_SHIFT) 
> Yes for the shifts it is needed, but not for the unshifted constants.
> I think. At least when they're hex the compiler should chose the right
> type on its own.

Only if the high bit is set.  But it should chose a big enough type.
However there is no reason to play games and possibly out smart ourselves.
That is the point of the _AC() macro.  It adds the suffix only for
C code, and drops it for assembly.

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to
More majordomo info at
Please read the FAQ at

Powered by blists - more mailing lists