linux-kernel - Re: [2.6 patch] arch/i386/kernel/io_apic.c: handle a negative return value

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <1163486812.28401.42.camel@earth>
Date:	Tue, 14 Nov 2006 07:46:52 +0100
From:	Ingo Molnar <mingo@...hat.com>
To:	Andrew Morton <akpm@...l.org>
Cc:	Adrian Bunk <bunk@...sta.de>, linux-kernel@...r.kernel.org
Subject: Re: [2.6 patch] arch/i386/kernel/io_apic.c: handle a negative
	return value

On Mon, 2006-11-13 at 16:42 -0800, Andrew Morton wrote:
>         pin  = find_isa_irq_pin(8, mp_INT);
> +       if (pin == -1) {
> +               printk(KERN_ERR "unlock_ExtINT_logic:
> find_isa_irq_pin()
> +                               "failed\n");
> +               return;
> +       }
>         apic = find_isa_irq_apic(8, mp_INT);
> -       if (pin == -1)
> +       if (apic == -1) {
> +               printk(KERN_ERR "unlock_ExtINT_logic:
> find_isa_irq_apic()
> +                               "failed\n");
>                 return;
> +       } 

as i mentioned it in my mail yesterday, if find_isa_irq_apic() returns
-1 then find_isa_irq_pin() has to return -1 too. But this is obscure and
needs to be documented at least - and your patch is good for
documentation purposes too :-)

Acked-by: Ingo Molnar <mingo@...hat.com>

	Ingo

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/