linux-kernel - Re: [PATCH] Don't give bad kprobes example aka ")

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20061115115716.GA923@infradead.org>
Date:	Wed, 15 Nov 2006 11:57:16 +0000
From:	Christoph Hellwig <hch@...radead.org>
To:	Alexey Dobriyan <adobriyan@...nvz.org>
Cc:	akpm@...l.org, linux-kernel@...r.kernel.org, devel@...nvz.org
Subject: Re: [PATCH] Don't give bad kprobes example aka ") < 0))" typo

On Wed, Nov 15, 2006 at 06:56:19PM +0300, Alexey Dobriyan wrote:
> Signed-off-by: Alexey Dobriyan <adobriyan@...nvz.org>
> ---
> 
>  Documentation/kprobes.txt |    5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> --- a/Documentation/kprobes.txt
> +++ b/Documentation/kprobes.txt
> @@ -442,9 +442,10 @@ static int __init kprobe_init(void)
>  	kp.fault_handler = handler_fault;
>  	kp.symbol_name = "do_fork";
>  
> -	if ((ret = register_kprobe(&kp) < 0)) {
> +	ret = register_kprobe(&kp);
> +	if (ret < 0) {
>  		printk("register_kprobe failed, returned %d\n", ret);
> -		return -1;
> +		return ret;

This looks good, thanks.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/