linux-kernel - Re: [PATCH] Use delayed disable mode of ioapic edge triggered interrupts

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <11129007.324261163594437361.komurojun-mbn@nifty.com>
Date:	Wed, 15 Nov 2006 21:40:37 +0900 (JST)
From:	Komuro <komurojun-mbn@...ty.com>
To:	"Eric W. Biederman" <ebiederm@...ssion.com>
Cc:	Linus Torvalds <torvalds@...l.org>, Ingo Molnar <mingo@...hat.com>,
	Komuro <komurojun-mbn@...ty.com>, tglx@...utronix.de,
	Adrian Bunk <bunk@...sta.de>, Andrew Morton <akpm@...l.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] Use delayed disable mode of ioapic edge triggered interrupts

Hi,

I tried the Eric's patch instead of Ingo's
with 2.6.19-rc5.


The interrupt is generated properly.

Thanks!

Best Regards
Komuro


>
>Hopefully this is the trivial patch that solves the problem.
>
>Signed-off-by: Eric W. Biederman <ebiederm@...ssion.com>
>
>diff --git a/arch/i386/kernel/io_apic.c b/arch/i386/kernel/io_apic.c
>index ad84bc2..3b7a63e 100644
>--- a/arch/i386/kernel/io_apic.c
>+++ b/arch/i386/kernel/io_apic.c
>@@ -1287,9 +1287,11 @@ static void ioapic_register_intr(int irq
> 			trigger == IOAPIC_LEVEL)
> 		set_irq_chip_and_handler_name(irq, &ioapic_chip,
> 					 handle_fasteoi_irq, "fasteoi");
>-	else
>+	else {
>+		irq_desc[irq].status |= IRQ_DELAYED_DISABLE;
> 		set_irq_chip_and_handler_name(irq, &ioapic_chip,
> 					 handle_edge_irq, "edge");
>+	}
> 	set_intr_gate(vector, interrupt[irq]);
> }
> 
>diff --git a/arch/x86_64/kernel/io_apic.c b/arch/x86_64/kernel/io_apic.c
>index 41bfc49..14654e6 100644
>--- a/arch/x86_64/kernel/io_apic.c
>+++ b/arch/x86_64/kernel/io_apic.c
>@@ -790,9 +790,11 @@ static void ioapic_register_intr(int irq
> 			trigger == IOAPIC_LEVEL)
> 		set_irq_chip_and_handler_name(irq, &ioapic_chip,
> 					      handle_fasteoi_irq, "fasteoi");
>-	else
>+	else {
>+		irq_desc[irq].status |= IRQ_DELAYED_DISABLE;
> 		set_irq_chip_and_handler_name(irq, &ioapic_chip,
> 					      handle_edge_irq, "edge");
>+	}
> }
> 
> static void __init setup_IO_APIC_irqs(void)
>

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/