[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <Pine.LNX.4.64.0611151658520.24160@blonde.wat.veritas.com>
Date: Wed, 15 Nov 2006 17:01:54 +0000 (GMT)
From: Hugh Dickins <hugh@...itas.com>
To: Jan Beulich <jbeulich@...ell.com>
cc: Andi Kleen <ak@...e.de>, linux-kernel@...r.kernel.org,
patches@...-64.org
Subject: Re: [PATCH] x86-64: adjust pmd_bad()
On Wed, 15 Nov 2006, Jan Beulich wrote:
> Make pmd_bad() symmetrical to pgd_bad() and pud_bad(). At once,
> simplify them all.
Symmetrical and simpler, yes, but you're weakening the pmd_bad() test:
no longer requires that all those _KERNPG_TABLE bits be set. Wouldn't
it be better to go the other way and strengthen pgd_bad, pud_bad?
Hugh
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists