linux-kernel - [PATCH 25/19] FS-Cache: NFS: Wait in releasepage() if FS-Cache is busy and __GFP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <899.1163611346@redhat.com>
Date:	Wed, 15 Nov 2006 17:22:26 +0000
From:	David Howells <dhowells@...hat.com>
To:	trond.myklebust@....uio.no, torvalds@...l.org, akpm@...l.org,
	sds@...ho.nsa.gov
Cc:	dhowells@...hat.com, selinux@...ho.nsa.gov,
	linux-kernel@...r.kernel.org, aviro@...hat.com, steved@...hat.com
Subject: [PATCH 25/19] FS-Cache: NFS: Wait in releasepage() if FS-Cache is busy and __GFP_WAIT is set


Make NFS wait in its releasepage() op if FS-Cache is busy with a page and
__GFP_WAIT was supplied in the gfp parameter rather than returning false to the
VM.

Signed-Off-By: David Howells <dhowells@...hat.com>
---

 fs/nfs/file.c    |    2 +-
 fs/nfs/fscache.h |    9 ++++++---
 2 files changed, 7 insertions(+), 4 deletions(-)

diff --git a/fs/nfs/file.c b/fs/nfs/file.c
index 9da03ec..6ac3ac7 100644
--- a/fs/nfs/file.c
+++ b/fs/nfs/file.c
@@ -350,7 +350,7 @@ static int nfs_release_page(struct page 
 	if (nfs_wb_page(page->mapping->host, page) < 0)
 		return 0;
 
-	if (nfs_fscache_release_page(page) < 0)
+	if (nfs_fscache_release_page(page, gfp) < 0)
 		return 0;
 
 	/* PG_private may have been set due to either caching or writing */
diff --git a/fs/nfs/fscache.h b/fs/nfs/fscache.h
index 92c2dbf..c363421 100644
--- a/fs/nfs/fscache.h
+++ b/fs/nfs/fscache.h
@@ -238,10 +238,13 @@ static inline void nfs_fscache_install_v
  * release the caching state associated with a page, if the page isn't busy
  * interacting with the cache
  */
-static inline int nfs_fscache_release_page(struct page *page)
+static inline int nfs_fscache_release_page(struct page *page, gfp_t gfp)
 {
-	if (PageFsMisc(page))
-		return -EBUSY;
+	if (PageFsMisc(page)) {
+		if (!(gfp & __GFP_WAIT))
+			return -EBUSY;
+		wait_on_page_fs_misc(page);
+	}
 
 	if (PageNfsCached(page)) {
 		struct nfs_inode *nfsi = NFS_I(page->mapping->host);
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/