linux-kernel - Re: [PATCH] Fix strange size check in __get_vm_area

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <200611151851.09649.dada1@cosmosbay.com>
Date:	Wed, 15 Nov 2006 18:51:09 +0100
From:	Eric Dumazet <dada1@...mosbay.com>
To:	OGAWA Hirofumi <hirofumi@...l.parknet.co.jp>
Cc:	Andrew Morton <akpm@...l.org>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Fix strange size check in __get_vm_area_node()

On Wednesday 15 November 2006 18:39, OGAWA Hirofumi wrote:
> Recently, __get_vm_area_node() was changed like following
>
>  	if (unlikely(!area))
>  		return NULL;
>
> -	if (unlikely(!size)) {
> -		kfree (area);
> +	if (unlikely(!size))
>  		return NULL;
> -	}
>
> It is leaking `area', also original code seems strange already.
> Probably, we wanted to do this patch.
>

Indeed. I checked my original patch and it was correct. I dont know what 
happened then...

http://lkml.org/lkml/2006/10/23/86

Eric
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/