linux-kernel - Re: [PATCH] ALSA: hda-intel - Disable MSI support by default

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <455B5F01.7020601@garzik.org>
Date:	Wed, 15 Nov 2006 13:40:01 -0500
From:	Jeff Garzik <jeff@...zik.org>
To:	Linus Torvalds <torvalds@...l.org>
CC:	Arjan van de Ven <arjan@...radead.org>,
	Takashi Iwai <tiwai@...e.de>,
	David Miller <davem@...emloft.net>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ALSA: hda-intel - Disable MSI support by default

Linus Torvalds wrote:
> And the thing is, once you do that, all the advantages of MSI totally go 
> away - both the "nice" ones and the "really good ones" (the latter being 
> the hopeful eventual removal of irq routing confusions). So if you do 
> that, the better solution is for the driver to say "I won't use MSI at 
> all".

I certainly agree with this.

The driver should either (a) know MSI works for the device [it calls 
pci_msi_enable()] or (b) never bothers with MSI.

Combine that with accurate pci_msi_enable() failure, and life is good.

No 'test if MSI works' crapola in drivers.  I've disliked such tests 
since the day MSI was introduced into Linux.


> It all boils down to the same thing: either we have to know that MSI works 
> (where "know" is obviously relative - it's not like you can avoid _all_ 
> bugs, but dammit, even a single report of "not working" means that there 
> are probably a ton of machines like that, and we did something wrong), or 
> we shouldn't use it. There is no middle ground. You can't really safely 
> "test" for it, and while you _can_ say "just do both", it doesn't really 
> help anything (and potentially exposes you to just more bugs: if enablign 
> MSI actually _does_ disable INTx, but then doesn't work, at a minimum you 
> end up with a device that doesn't work, even if the rest of the kernel 
> might be ok).

Agreed.


> And btw, I say this as a person whose new main machine used to have HDA 
> routed over MSI, and the decision to default to it off meant that it went 
> back to the regular INTx thing.

Yeah, but you don't care if that happens, so this is an ineffective 
'btw'  It's not like you went to sleep crying over the loss, like I did 
[just kidding!]


> (Btw, MSI interrupts also seem to not participate in CPU balancing:
> 
>  22:      41556      43005   IO-APIC-fasteoi   HDA Intel
> 506:     110417          0   PCI-MSI-edge      eth0
> 
> which is another semantic change introduced by using MSI)

No, that's most likely because ethernet is always intentionally locked 
to a single CPU by irqbalance.

	Jeff



-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/