linux-kernel - Re: [PATCH] ALSA: hda-intel - Disable MSI support by default

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <adad57oy2el.fsf@cisco.com>
Date:	Wed, 15 Nov 2006 10:45:38 -0800
From:	Roland Dreier <rdreier@...co.com>
To:	Linus Torvalds <torvalds@...l.org>
Cc:	Jeff Garzik <jeff@...zik.org>, David Miller <davem@...emloft.net>,
	linux-kernel@...r.kernel.org, tiwai@...e.de
Subject: Re: [PATCH] ALSA: hda-intel - Disable MSI support by default

 > > Huh?  The device can't generate any legacy interrupts once MSI is
 > > enabled.  As the PCI spec says:
 > 
 > PLEASE.
 > 
 > The spec is just so much toilet paper. The ONLY thing that matters is what 
 > real hardware does. So please please please PLEASE don't start quoting 
 > specs as a way to "prove your point". It is totally meaningless.

Sorry, I think you misunderstood.  I've certainly seen my share of
crazy devices doing things like endian-reversing the MSI address and
sending interrupt messages off into random space.  The only thing I
was disagreeing with was that Jeff suggested it was a driver bug not
to do pci_intx(0) when enabling MSI.

I don't doubt that there are broken devices out there that do generate
wire interrupts even when MSI is enabled.  I just don't think we
should go around "fixing" working, correct drivers for devices that
_do_ follow the spec.

 - R.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/