linux-kernel - Re: [PATCH] ALSA: hda-intel - Disable MSI support by default

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <455B7E3F.6040403@trollprod.org>
Date:	Wed, 15 Nov 2006 21:53:19 +0100
From:	Olivier Nicolas <olivn@...llprod.org>
To:	Linus Torvalds <torvalds@...l.org>
CC:	Mws <mws@...sted-brains.org>, Jeff Garzik <jeff@...zik.org>,
	Krzysztof Halasa <khc@...waw.pl>,
	David Miller <davem@...emloft.net>,
	linux-kernel@...r.kernel.org, tiwai@...e.de, yinghai.lu@....com
Subject: Re: [PATCH] ALSA: hda-intel - Disable MSI support by default

Linus Torvalds wrote:
> 
> On Wed, 15 Nov 2006, Mws wrote:
>> after some small discussions on alsa-user ml i recognised this
>> thread today. 
>> i thought my problem could also exist on this msi stuff.
>> i disabled msi in kernel config, reboot, and, after starting x & kde
>> i got immediately a freeze.
>> last and maybe important last try has been to
>> enable msi support _but_ boot kernel with cmdline pci=nomsi
>> this finally did work out. i got a working sound environment again.

Usually, the shared IRQ is disabled but it has happened that the system 
boots without disabling the IRQ. In that case, the sound is distorted 
and the distortion increase when I use the device that shares the IRQ.
(see the boot messages: 
http://olivn.trollprod.org/irq_not_disabled_sound_distortion.dmesg )


I can boot the system with pci=nomsi without any problem.


Yinghai Lu who send me some patches to trace irq assignment
said:
"Then it is not caused by transition from MSI to IOAPIC.
Weird,
MSI is enabled, but chip still send int to ioapic.
YH"



Olivier

> 
> I expect that you have the exact same issue as Olivier: the "hang" is 
> probably because you started using the sound device (beeping on the 
> console is handled by the old built-in speaker, but in X a single beep 
> tends to be due to sound device drivers), and because of sound irq 
> misrouting you had some other device (like your harddisk) that got their 
> irq disabled due to the "nobody cared" issue.
> 
>> i find it a bit abnormal that the disabling msi in kernel config behaviour
>> is different from kernel cmdline pci=nomsi option.
> 
> Now, that does actually worry me. It _should_ have worked with CONFIG_MSI 
> disabled. I wonder if some of the MSI workarounds actually broke the HDA 
> driver subtly.
> 
> Anyway, it would be a good idea to test the current -git tree if you can, 
> both with CONFIG_MSI and without (and _without_ any "pci=nomsi" kernel 
> command line). It should hopefully work, exactly because the HDA driver 
> now shouldn't even try to do any MSI stuff by default.
> 
> Knock wood.
> 
> 		Linus


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/