linux-kernel - Re: [PATCH] sbp2: make 1bit bitfield unsigned

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20061115150919.330b8e9a.randy.dunlap@oracle.com>
Date:	Wed, 15 Nov 2006 15:09:19 -0800
From:	Randy Dunlap <randy.dunlap@...cle.com>
To:	Mariusz Kozlowski <m.kozlowski@...land.pl>
Cc:	Stefan Richter <stefanr@...6.in-berlin.de>,
	Luca Tettamanti <kronos.it@...il.com>,
	Ben Collins <bcollins@...ian.org>,
	Andrew Morton <akpm@...l.org>,
	linux1394-devel@...ts.sourceforge.net, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] sbp2: make 1bit bitfield unsigned

On Thu, 16 Nov 2006 00:04:24 +0100 Mariusz Kozlowski wrote:

> Hello,
> 
> > Luca Tettamanti wrote:
> > > A signed single-bit bitfield doesn't make much sense. Make it unsigned.
> > ...
> > Committed to linux1394-2.6.git.
> 
> There is a few more. Hopefuly 'grep + my eyes' caught them all.
> The patch is against 2.6.19-rc5-mm2.

'sparse' will catch them for sure.

ISDN, dvb, alsa patches need to be sent to different maintainers...

'diffstat -p1 -w70' output would be nice.

> Signed-of-by: Mariusz Kozlowski <m.kozlowski@...land.pl>
> 
> diff -upr linux-2.6.19-rc5-mm2-a/drivers/isdn/hisax/isdnhdlc.h linux-2.6.19-rc5-mm2-b/drivers/isdn/hisax/isdnhdlc.h
> --- linux-2.6.19-rc5-mm2-a/drivers/isdn/hisax/isdnhdlc.h	2006-11-15 11:24:19.000000000 +0100
> +++ linux-2.6.19-rc5-mm2-b/drivers/isdn/hisax/isdnhdlc.h	2006-11-15 23:54:15.000000000 +0100
> @@ -41,10 +41,10 @@ struct isdnhdlc_vars {
>  	unsigned char shift_reg;
>  	unsigned char ffvalue;
> 
> -	int data_received:1; 	// set if transferring data
> -	int dchannel:1; 	// set if D channel (send idle instead of flags)
> -	int do_adapt56:1; 	// set if 56K adaptation
> -        int do_closing:1; 	// set if in closing phase (need to send CRC + flag
> +	unsigned int data_received:1; 	// set if transferring data
> +	unsigned int dchannel:1; 	// set if D channel (send idle instead of flags)
> +	unsigned int do_adapt56:1; 	// set if 56K adaptation
> +	unsigned int do_closing:1; 	// set if in closing phase (need to send CRC + flag
>  };
> 
> 
> diff -upr linux-2.6.19-rc5-mm2-a/drivers/media/dvb/frontends/l64781.c linux-2.6.19-rc5-mm2-b/drivers/media/dvb/frontends/l64781.c
> --- linux-2.6.19-rc5-mm2-a/drivers/media/dvb/frontends/l64781.c	2006-11-08 03:24:20.000000000 +0100
> +++ linux-2.6.19-rc5-mm2-b/drivers/media/dvb/frontends/l64781.c	2006-11-15 21:35:33.000000000 +0100
> @@ -36,7 +36,7 @@ struct l64781_state {
>  	struct dvb_frontend frontend;
> 
>  	/* private demodulator data */
> -	int first:1;
> +	unsigned int first:1;
>  };
> 
>  #define dprintk(args...) \
> diff -upr linux-2.6.19-rc5-mm2-a/sound/arm/sa11xx-uda1341.c linux-2.6.19-rc5-mm2-b/sound/arm/sa11xx-uda1341.c
> --- linux-2.6.19-rc5-mm2-a/sound/arm/sa11xx-uda1341.c	2006-11-08 03:24:20.000000000 +0100
> +++ linux-2.6.19-rc5-mm2-b/sound/arm/sa11xx-uda1341.c	2006-11-15 21:40:16.000000000 +0100
> @@ -125,7 +125,7 @@ struct audio_stream {
>  #else
>  	dma_regs_t *dma_regs;	/* points to our DMA registers */
>  #endif
> -	int active:1;		/* we are using this stream for transfer now */
> +	unsigned int active:1;	/* we are using this stream for transfer now */
>  	int period;		/* current transfer period */
>  	int periods;		/* current count of periods registerd in the DMA engine */
>  	int tx_spin;		/* are we recoding - flag used to do DMA trans. for sync */
> 
> 
> -- 

---
~Randy
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/