linux-kernel - Re: 2.6.19-rc5 nasty ACPI regression, AE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200611151356.52985.david-b@pacbell.net>
Date:	Wed, 15 Nov 2006 13:56:52 -0800
From:	David Brownell <david-b@...bell.net>
To:	Alexey Starikovskiy <alexey.y.starikovskiy@...ux.intel.com>
Cc:	Len Brown <lenb@...nel.org>,
	Linux Kernel list <linux-kernel@...r.kernel.org>,
	linux-acpi@...r.kernel.org
Subject: Re: 2.6.19-rc5 nasty ACPI regression, AE_TIME errors

On Wednesday 15 November 2006 6:48 am, Alexey Starikovskiy wrote:
> ec1.patch
> 
> 
> Always enable GPE after return from notify handler.
> 
> From:  Alexey Starikovskiy <alexey.y.starikovskiy@...ux.intel.com>
> 
> 
> ---

Yes, this seems to resolve the regression as well as Len's ec_intr=0 boot param.

IMO this should get merged into 2.6.19 ASAP ...


>  drivers/acpi/ec.c |    2 --
>  1 files changed, 0 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/acpi/ec.c b/drivers/acpi/ec.c
> index e6d4b08..937eafc 100644
> --- a/drivers/acpi/ec.c
> +++ b/drivers/acpi/ec.c
> @@ -465,8 +465,6 @@ static u32 acpi_ec_gpe_handler(void *dat
>  
>         if (value & ACPI_EC_FLAG_SCI) {
>                 status = acpi_os_execute(OSL_EC_BURST_HANDLER, acpi_ec_gpe_query, ec);
> -               return status == AE_OK ?
> -                   ACPI_INTERRUPT_HANDLED : ACPI_INTERRUPT_NOT_HANDLED;
>         }
>         acpi_enable_gpe(NULL, ec->gpe_bit, ACPI_ISR);
>         return status == AE_OK ?
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/