linux-kernel - Re: 2.6.19-rc5-mm2 -- bcm43xx busted (backing out the bcm43xx patches fixes it)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <a44ae5cd0611152145k1af580fcsf0c983934978a241@mail.gmail.com>
Date:	Wed, 15 Nov 2006 21:45:52 -0800
From:	"Miles Lane" <miles.lane@...il.com>
To:	"Larry Finger" <Larry.Finger@...inger.net>
Cc:	"Rafael J. Wysocki" <rjw@...k.pl>,
	"John W. Linville" <linville@...driver.com>,
	"Andrew Morton" <akpm@...l.org>, Bcm43xx-dev@...ts.berlios.de,
	"Michael Buesch" <mb@...sch.de>,
	LKML <linux-kernel@...r.kernel.org>,
	netdev <netdev@...r.kernel.org>
Subject: Re: 2.6.19-rc5-mm2 -- bcm43xx busted (backing out the bcm43xx patches fixes it)

On 11/15/06, Larry Finger <Larry.Finger@...inger.net> wrote:
> Rafael J. Wysocki wrote:
> > On Wednesday, 15 November 2006 00:21, Miles Lane wrote:
> >> Hello,
> >>
> >> The last three MM kernels have fail to give me a working bcm43xx driver.
> >> The odd thing is that dmesg output seems to indicate that the driver
> >> is working okay.  NetworkManager doesn't see the driver, though.
> >> "iwlist scan" fails to find any access points, too.  iwconfig shows
> >> "Access Point: invalid".
> >
> > I can confirm the symptoms, I see them too on my test boxes.
> >
> >> I tried backing out the following patches, and it fixes the problem:
> >>
> >> drivers/net/wireless/bcm43xx/bcm43xx.h
> >> drivers/net/wireless/bcm43xx/bcm43xx_main.c
> >> drivers/net/wireless/bcm43xx/bcm43xx_power.c
> >> drivers/net/wireless/bcm43xx/bcm43xx_wx.c
> >>> drivers/net/wireless/bcm43xx/bcm43xx_xmit.c
>
> The missing patch is shown below. This patch was entitled "[PATCH] bcm43xx: Readd dropped
> assignment" and submitted to wireless-2.6 by Daniel Drake on 10/17/06, but it seems to have fallen
> through the cracks. It is a fix to a patch entitled "[PATCH] ieee80211: Move IV/ICV stripping into
> ieee80211_rx" also submitted by Daniel Drake on 9/26/2006.
>
> NOTE to maintainers: This problem affects BOTH wireless-2.6 and 2.6.19-rcX-mmY. At present, the
> "Move IV/ICV" patch has not been incorporated into 2.6.19-rcX and it is OK.
>
> Larry
>
>
> In the patch sent by Daniel Drake under the title "[PATCH] ieee80211: Move
> IV/ICV stripping into ieee80211_rx", a needed line was accidentally removed.
> As my current copy of wireless-2.6.git does not contain this line, I am
> (re)submitting a patch to restore that line.
>
> Signed-off-by: Larry Finger <Larry.Finger@...inger.net>
> ---
>
> Index: wireless-2.6/drivers/net/wireless/bcm43xx/bcm43xx_xmit.c
> ===================================================================
> --- wireless-2.6.orig/drivers/net/wireless/bcm43xx/bcm43xx_xmit.c
> +++ wireless-2.6/drivers/net/wireless/bcm43xx/bcm43xx_xmit.c
> @@ -543,6 +543,7 @@ int bcm43xx_rx(struct bcm43xx_private *b
>                 break;
>         }
>
> +       frame_ctl = le16_to_cpu(wlhdr->frame_ctl);
>         switch (WLAN_FC_GET_TYPE(frame_ctl)) {
>         case IEEE80211_FTYPE_MGMT:
>                 ieee80211_rx_mgt(bcm->ieee, wlhdr, &stats);
>
>

Thanks!  I have verified that this patch solves the problem for me.

      Miles
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/