linux-kernel - Re: [patch, -rc6] x86

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 16 Nov 2006 11:09:37 +0100
From:	Andi Kleen <ak@...e.de>
To:	Ingo Molnar <mingo@...e.hu>
Cc:	Andrew Morton <akpm@...l.org>, Linus Torvalds <torvalds@...l.org>,
	linux-kernel@...r.kernel.org
Subject: Re: [patch, -rc6] x86_64: UP build fixes

On Thursday 16 November 2006 10:48, Ingo Molnar wrote:
> 
> * Andi Kleen <ak@...e.de> wrote:
> 
> > On Thursday 16 November 2006 10:17, Andrew Morton wrote:
> > > On Thu, 16 Nov 2006 10:01:01 +0100
> > > Andi Kleen <ak@...e.de> wrote:
> > > 
> > > > +#ifdef CONFIG_HOTPLUG_CPU
> > > >  	hotcpu_notifier(cpu_vsyscall_notifier, 0);
> > > > +#endif
> > > 
> > > this part isn't needed - the definition handles that.
> > 
> > Thanks. Updated patch appended.
> 
> my hotplug-CPU cleanup patch solves this in a cleaner way: by removing 
> all those #ifdefs as well.

Fine, but I suspect that late in the release it's better to go 
for minimal "obvious" fixes. Later it can then be cleaned up properly.

-Andi
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/