linux-kernel - [PATCH] usb: pwc-if loop fix

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <200611161639.05830.m.kozlowski@tuxland.pl>
Date:	Thu, 16 Nov 2006 16:38:57 +0100
From:	Mariusz Kozlowski <m.kozlowski@...land.pl>
To:	Luc Saillard <luc@...llard.org>, Greg KH <greg@...ah.com>
Cc:	linux-usb-devel@...ts.sourceforge.net, linux-kernel@...r.kernel.org
Subject: [PATCH] usb: pwc-if loop fix

Hello,

	We should free urbs starting at [i-1] not [i].

Signed-off-by: Mariusz Kozlowski <m.kozlowski@...land.pl>

drivers/media/video/pwc/pwc-if.c |    3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff -upr linux-2.6.19-rc5-mm2-a/drivers/media/video/pwc/pwc-if.c linux-2.6.19-rc5-mm2-b/drivers/media/video/pwc/pwc-if.c
--- linux-2.6.19-rc5-mm2-a/drivers/media/video/pwc/pwc-if.c	2006-11-15 11:24:20.000000000 +0100
+++ linux-2.6.19-rc5-mm2-b/drivers/media/video/pwc/pwc-if.c	2006-11-15 21:08:07.000000000 +0100
@@ -866,10 +866,9 @@ int pwc_isoc_init(struct pwc_device *pde
 	}
 	if (ret) {
 		/* De-allocate in reverse order */
-		while (i >= 0) {
+		while (i--) {
 			usb_free_urb(pdev->sbuf[i].urb);
 			pdev->sbuf[i].urb = NULL;
-			i--;
 		}
 		return ret;
 	}

-- 
Regards,

	Mariusz Kozlowski
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/