linux-kernel - Re: [linux-usb-devel] [PATCH] usb: microtek possible memleak fix

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <200611162215.00934.m.kozlowski@tuxland.pl>
Date:	Thu, 16 Nov 2006 22:14:58 +0100
From:	Mariusz Kozlowski <m.kozlowski@...land.pl>
To:	Oliver Neukum <oliver@...kum.name>
Cc:	linux-usb-devel@...ts.sourceforge.net, Greg KH <greg@...ah.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [linux-usb-devel] [PATCH] usb: microtek possible memleak fix

Hello, 

> Ist there a reason you are replacing at least somewhat descriptive labels
> with numbers?

Yes.

To me these numbers speak more than not really descriptive labels like
out_kfree out_kfree2 etc. I look at the code and see the flow. The most
important thing here is the order in which the resources are allocated and
if something goes wrong deallocated. Hence the numbers.

Anyway if that's a problem I can rewrite it.

-- 
Regards,

	Mariusz Kozlowski
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/