linux-kernel - Re: [patch] hotplug CPU: clean up hotcpu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.64.0611161357380.3349@woody.osdl.org>
Date:	Thu, 16 Nov 2006 13:59:06 -0800 (PST)
From:	Linus Torvalds <torvalds@...l.org>
To:	Ingo Molnar <mingo@...e.hu>
cc:	Andrew Morton <akpm@...l.org>, Andi Kleen <ak@...e.de>,
	linux-kernel@...r.kernel.org
Subject: Re: [patch] hotplug CPU: clean up hotcpu_notifier() use



On Thu, 16 Nov 2006, Ingo Molnar wrote:
>
> the cpu-hotplug related warning is solved by the cleanup below.

I do not believe this is a cleanup, at least not in this kind of form:

> @@ -1777,8 +1775,8 @@ xfs_icsb_init_counters(
>  #ifdef CONFIG_HOTPLUG_CPU
>  	mp->m_icsb_notifier.notifier_call = xfs_icsb_cpu_notify;
>  	mp->m_icsb_notifier.priority = 0;
> -	register_hotcpu_notifier(&mp->m_icsb_notifier);
>  #endif /* CONFIG_HOTPLUG_CPU */
> +	register_hotcpu_notifier(&mp->m_icsb_notifier);

That's just horrible. Now you "register" that notifier that you've never 
actually even initialized.

The new code is a lot worse than the old code at least in this case.

		Linus
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/