linux-kernel - RE: [PATCH 2.6.19-rc5-mm2] cpufreq: set policy->curfreq on initialization

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <EB12A50964762B4D8111D55B764A8454E7610F@scsmsx413.amr.corp.intel.com>
Date:	Fri, 17 Nov 2006 06:01:45 -0800
From:	"Pallipadi, Venkatesh" <venkatesh.pallipadi@...el.com>
To:	"Mattia Dongili" <malattia@...ux.it>, <ego@...ibm.com>,
	"Reuben Farrelly" <reuben-linuxkernel@...b.net>,
	"Andrew Morton" <akpm@...l.org>, <davej@...hat.com>,
	<linux-kernel@...r.kernel.org>,
	"CPUFreq Mailing List" <cpufreq@...ts.linux.org.uk>,
	"Sadykov, Denis M" <denis.m.sadykov@...el.com>
Subject: RE: [PATCH 2.6.19-rc5-mm2] cpufreq: set policy->curfreq on initialization


Acked.
Andrew: Please include this patch in mm.

Thanks,
Venki 

>-----Original Message-----
>From: Mattia Dongili [mailto:malattia@...ux.it] 
>Sent: Wednesday, November 15, 2006 11:05 AM
>To: Pallipadi, Venkatesh; ego@...ibm.com; Reuben Farrelly; 
>Andrew Morton; davej@...hat.com; linux-kernel@...r.kernel.org; 
>CPUFreq Mailing List; Sadykov, Denis M
>Subject: [PATCH 2.6.19-rc5-mm2] cpufreq: set policy->curfreq 
>on initialization
>
>
>Check the correct variable and set policy->cur upon acpi-cpufreq
>initialization to allow the userspace governor to be used as default.
>
>Signed-off-by: Mattia Dongili <malattia@...ux.it>
>
>---
>
>Reuben, could you also try if this patch fixes the BUG()?
>Thanks
>
>diff --git a/arch/i386/kernel/cpu/cpufreq/acpi-cpufreq.c 
>b/arch/i386/kernel/cpu/cpufreq/acpi-cpufreq.c
>index 18f4715..a630f94 100644
>--- a/arch/i386/kernel/cpu/cpufreq/acpi-cpufreq.c
>+++ b/arch/i386/kernel/cpu/cpufreq/acpi-cpufreq.c
>@@ -699,14 +699,14 @@ static int acpi_cpufreq_cpu_init(struct
> 	if (result)
> 		goto err_freqfree;
> 
>-	switch (data->cpu_feature) {
>+	switch (perf->control_register.space_id) {
> 	case ACPI_ADR_SPACE_SYSTEM_IO:
> 		/* Current speed is unknown and not detectable 
>by IO port */
> 		policy->cur = acpi_cpufreq_guess_freq(data, 
>policy->cpu);
> 		break;
> 	case ACPI_ADR_SPACE_FIXED_HARDWARE:
> 		acpi_cpufreq_driver.get = get_cur_freq_on_cpu;
>-		get_cur_freq_on_cpu(cpu);
>+		policy->cur = get_cur_freq_on_cpu(cpu);
> 		break;
> 	default:
> 		break;
>
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/