linux-kernel - Re: [v4l-dvb-maintainer] -mm: cx88-blackbird.c: unused code re-added

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1163772822.20349.37.camel@localhost>
Date:	Fri, 17 Nov 2006 12:13:42 -0200
From:	Mauro Carvalho Chehab <mchehab@...radead.org>
To:	Adrian Bunk <bunk@...sta.de>
Cc:	Andrew Morton <akpm@...l.org>, v4l-dvb-maintainer@...uxtv.org,
	linux-kernel@...r.kernel.org
Subject: Re: [v4l-dvb-maintainer] -mm: cx88-blackbird.c: unused code
	re-added

Hi Adrian,

Em Sex, 2006-11-17 às 13:42 +0100, Adrian Bunk escreveu:
> On Tue, Nov 14, 2006 at 01:41:25AM -0800, Andrew Morton wrote:
> >...
> > Changes since 2.6.19-rc5-mm2:
> >...
> >  git-dvb.patch
> >...
> >  git trees
> >...
> 
> Why does this patch re-add the still unused cx88_ioctl_hook and 
> cx88_ioctl_translator in drivers/media/video/cx88/cx88-blackbird.c 
> I removed a few months ago?
Hmm... I think I sent to my -git the patch that reenables it.

Let me explain a little bit about those hooks.

As you know, ivtv is being re-worked to be inserted at kernel. This
includes a complete API review of several ivtv calls. Some of they were
providing stuff already at V4L2 API, but implemented on a different way.
This turned into a huge project, being delayed with the first scheduling
time. First, we've migrated all i2c drivers. Then mpeg decoding. Now, we
are working at mpeg encoding part.

cx88-blackbird provides mpeg outputs for analog tv, in a similar way as
ivtv devices. However, some userspace apps were not implementing the
experimental mpeg support added at V4L2 api for mpeg streams, but
instead, were using an API developed for ivtv.

We received a patch for a cx88-ivtv module that allows using
ivtv-enabled programs to work with cx88-blackbird. 

To avoid causing later regressions of removing IVTV API calls from
kernel, we decided to create the hooks at kernel, and having cx88-ivtv
only at v4l-dvb tree. The proper API calls will be added as soon as ivtv
driver will be finished and the proper api is available to be
incorporated at cx88-blackbird.

Anyway, I've redesigned cx88 to use video_ioctl2 interface, who is
incompatible with the hooks. The newer approach is at:
http://www.linuxtv.org/hg/~mchehab/cx88_ioctls

After merging this branch into the v4l-dvb tree, the patches will be
removed. I intend to apply those changes to 2.6.20, so, there's no need
to worry about this stuff.

>  
> cu
> Adrian
> 
Cheers, 
Mauro.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/