linux-kernel - Re: [PATCH] SCSI: Add the SGPIO support for sata

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20061117150612.GC12227@zakalwe.fi>
Date:	Fri, 17 Nov 2006 17:06:12 +0200
From:	Heikki Orsila <shd@...alwe.fi>
To:	Peer Chen <pchen@...dia.com>
Cc:	Christoph Hellwig <hch@...radead.org>,
	Prakash Punnoor <prakash@...noor.de>,
	Andrew Morton <akpm@...l.org>, jeff@...zik.org,
	linux-kernel@...r.kernel.org, linux-ide@...r.kernel.org,
	Kuan Luo <kluo@...dia.com>
Subject: Re: [PATCH] SCSI: Add the SGPIO support for sata_nv.c

On Fri, Nov 17, 2006 at 04:36:37PM +0800, Peer Chen wrote:
> I didn't get any comment from you guys for new patch, does someone take
> care this patch, do we still need some modification upon it? Or do we
> need re-submit it in other thread?

One small change suggestion:

> +static inline bool nv_sgpio_capable(const struct pci_device_id *ent)         
> +{                                                                            
> +     if (ent->device == PCI_DEVICE_ID_NVIDIA_NFORCE_MCP55_SATA2)             
> +             return 1;                                                       
> +     else                                                                    
> +             return 0;                                                       
> +}                          

Make it shorter ->

	return ent->device == PCI_DEVICE_ID_NVIDIA_NFORCE_MCP55_SATA2;

 - Heikki
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/