linux-kernel - Re: [PATCH -mm] freeze/thaw fs when BLOCK=n

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20061117151820.GA8867@elf.ucw.cz>
Date:	Fri, 17 Nov 2006 16:18:21 +0100
From:	Pavel Machek <pavel@....cz>
To:	Randy Dunlap <randy.dunlap@...cle.com>
Cc:	lkml <linux-kernel@...r.kernel.org>, akpm <akpm@...l.org>,
	"Rafael J. Wysocki" <rjw@...k.pl>
Subject: Re: [PATCH -mm] freeze/thaw fs when BLOCK=n

Hi!

> From: Randy Dunlap <randy.dunlap@...cle.com>
> 
> Fix freeze/thaw filesystems with CONFIG_BLOCK disabled:
> kernel/power/process.c:124: warning: implicit declaration of function 'freeze_fil
> esystems'
> kernel/power/process.c:189: warning: implicit declaration of function 'thaw_files
> ystems'
> 
> Signed-off-by: Randy Dunlap <randy.dunlap@...cle.com>

I believe we'll simply want to remove {thaw,freeze}_filesystems. XFS
problem is solved with freezeable workqueues, and
{thaw,freeze}_filesystems has problems if someone is creating dm
snapshots in the meantime.
								Pavel

> ---
>  include/linux/buffer_head.h |    3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> --- linux-2619-rc5mm2.orig/include/linux/buffer_head.h
> +++ linux-2619-rc5mm2/include/linux/buffer_head.h
> @@ -314,7 +314,8 @@ static inline void invalidate_inode_buff
>  static inline int remove_inode_buffers(struct inode *inode) { return 1; }
>  static inline int sync_mapping_buffers(struct address_space *mapping) { return 0; }
>  static inline void invalidate_bdev(struct block_device *bdev, int destroy_dirty_buffers) {}
> -
> +static inline void freeze_filesystems(void) {}
> +static inline void thaw_filesystems(void) {}
>  
>  #endif /* CONFIG_BLOCK */
>  #endif /* _LINUX_BUFFER_HEAD_H */
> 
> 
> ---

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/