linux-kernel - Re: [patch 2/6] [RFC] Add MMC Password Protection (lock/unlock) support V6

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20061117160439.GB28514@flint.arm.linux.org.uk>
Date:	Fri, 17 Nov 2006 16:04:39 +0000
From:	Russell King <rmk+lkml@....linux.org.uk>
To:	Anderson Briglia <anderson.briglia@...t.org.br>
Cc:	"Linux-omap-open-source@...ux.omap.com" 
	<linux-omap-open-source@...ux.omap.com>,
	linux-kernel@...r.kernel.org,
	Pierre Ossman <drzeus-list@...eus.cx>,
	ext David Brownell <david-b@...bell.net>,
	Tony Lindgren <tony@...mide.com>,
	"Aguiar Carlos (EXT-INdT/Manaus)" <carlos.aguiar@...t.org.br>,
	"Biris Ilias (EXT-INdT/Manaus)" <Ilias.Biris@...t.org.br>
Subject: Re: [patch 2/6] [RFC] Add MMC Password Protection (lock/unlock) support V6

On Fri, Nov 17, 2006 at 09:02:10AM -0400, Anderson Briglia wrote:
> @@ -366,15 +434,33 @@ static int __init mmc_init(void)
>  	if (ret == 0) {
>  		ret = class_register(&mmc_host_class);
>  		if (ret)
> -			bus_unregister(&mmc_bus_type);
> +			goto error;
> +	}
> +#ifdef	CONFIG_MMC_PASSWORDS
> +	else {
> +		ret = register_key_type(&mmc_key_type);
> +		if (ret)
> +			goto error_mmc_pwd;

This is obviously untested - you won't get to register the key type if
bus_register() succeeds.  You actually only register it if bus_register()
fails.

-- 
Russell King
 Linux kernel    2.6 ARM Linux   - http://www.arm.linux.org.uk/
 maintainer of:  2.6 Serial core
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/